@mdedetrich Can't you use Assertions.assertThrows directly?

@mdedetrich Can't you use Assertions.assertThrows directly?

Not with a kotlin suspend function that you are asserting, thats the precise issue. It will fail to compile for the reasons I stated in the PR. Kotlin suspend only works if the assertThrow definitions are inline func (which Assertions.assertThrows is not since its written in Java) or if the block parameter argument has suspend func () -> definition.

Of course you could just do

Assertions.assertThrows(IllegalArgumentException::class.java) {
  runBlocking {
    someKotlinSuspendFunc()
  }
}

But one of the whole point of org.junit.jupiter.api.* assert functions existing is so that they can work with kotlin coroutines directly without the using of runBlocking/runTest.

I have just rebased the PR against latest main to resolve conflicts.

Kotlin suspend only works if the assertThrow definitions are inline func

Sorry for making you re-explain it. I didn't read carefully enough. 😬

I wonder whether having the reified and the new variants is confusing and we should deprecate the old ones. WDYT? 🤔

I wonder whether having the reified and the new variants is confusing and we should deprecate the old ones. WDYT? 🤔

I personally see value in both and actually prefer the original variants. Its just that there are some cases where you are using exceptions as values (i.e. @ParameterizedTest) and there isn't anything you can do about it.

While its true that there are a lot of overloads, the design is intelligent in that the ones that use exception values always have exception as first arg so the quality of life of users with IDE's should be a non issue (talking about ergonomics of finding the right overload).

tld;r I think its a non issue and there is value in both cases, like generally with JVM languages in some cases you treat types as values and in other cases as type parameters.

✅ All tests passed ✅

🏷️ Commit: d3494e9
▶️ Tests: 38566 executed
⚪️ Checks: 17/17 completed

Learn more about TestLens at testlens.app.